woofmeow/straywild
woofmeow/straywild
3
5
Fork 2
Code Issues 36 Projects 1 Releases 43 Packages Wiki Activity Actions

fix: isolate controller settings side effects

Browse source
This commit is contained in:
Alexander Sellite 2026-08-16 20:53:15 -04:00
parent a8be597d27
commit 7aaed6393b
6 changed files with 40 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/controller_menu_accessibility_validation.gd
View file

@ -210,6 +210,25 @@ func _validate_join_game_navigation() -> void:
func _validate_data_settings_navigation() -> void:
var main_source: String = FileAccess.get_file_as_string("res://main/main.gd")
var data_root_source: String = FileAccess.get_file_as_string(
"res://network/player_data_root.gd"
)
var settings_source: String = FileAccess.get_file_as_string(
"res://ui/settings_panel.gd"
)
_expect(
not main_source.contains("OS.shell_open")
and not main_source.contains(
"status_changed.connect(_on_data_root_status)"
)
and not data_root_source.contains("OS.shell_open")
and settings_source.count("OS.shell_open") == 1,
(
"Opening the data folder is not owned exclusively by the Settings "
+ "Data action."
),
)
var panel := SettingsPanelScene.instantiate() as SettingsPanel
root.add_child(panel)
await process_frame