makearmy/v2026.04.02
1
0
Fork 0
mirror of https://github.com/Abdess/retrobios.git synced 2026-06-24 12:02:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: fix code review findings across all scripts

Browse source 
Critical: stream large file downloads (OOM fix), fix basename match
in auto_fetch, include hashes in pack grouping fingerprint, handle
not_in_zip status in verify, fix escaped quotes in batocera parser.

Important: deduplicate shared group includes, catch coreinfo network
errors, fix NODEDUP path component match, fix CI word splitting on
spaces, replace bare except Exception in 3 files.

Minor: argparse in list_platforms, specific exceptions in download.py.
This commit is contained in:
Abdessamad Derraz 2026-03-17 15:16:51 +01:00
parent ff38eebde7
commit af74fffa14
11 changed files with 41 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

3
scripts/dedup.py
View file

@ -55,7 +55,8 @@ def path_priority(path: str) -> tuple:
def _in_nodedup_dir(path: str) -> bool:
"""Check if a file is inside a no-dedup directory."""
return any(nodedup in path for nodedup in NODEDUP_DIRS)
parts = Path(path).parts
return any(nodedup in parts for nodedup in NODEDUP_DIRS)
def scan_duplicates(bios_dir: str) -> dict[str, list[str]]: