prefilled settings edits

This commit is contained in:
makearmy 2025-10-03 22:54:05 -04:00
parent 7e9b5adfa8
commit 494f5525af
2 changed files with 259 additions and 227 deletions

View file

@ -10,9 +10,10 @@ type Rec = {
setting_title?: string | null;
setting_notes?: string | null;
photo?: { id?: string } | string | number | null;
screen?: { id?: string } | string | number | null;
photo?: { id?: string } | string | null;
screen?: { id?: string } | string | null;
// ids & readable fields
mat?: { id?: string | number; name?: string | null } | null;
mat_coat?: { id?: string | number; name?: string | null } | null;
mat_color?: { id?: string | number; name?: string | null } | null;
@ -23,7 +24,7 @@ type Rec = {
lens?: { id?: string | number; field_size?: string | number | null; focal_length?: string | number | null } | null;
focus?: number | null;
laser_soft?: any;
laser_soft?: { id?: string | number; name?: string | null } | string | number | null;
repeat_all?: number | null;
fill_settings?: any[] | null;
@ -32,6 +33,7 @@ type Rec = {
owner?: { id?: string | number; username?: string | null } | string | number | null;
uploader?: string | null;
last_modified_date?: string | null;
};
@ -40,22 +42,35 @@ async function readJson(res: Response) {
try { return text ? JSON.parse(text) : null; } catch { throw new Error(`Unexpected response (HTTP ${res.status})`); }
}
const ownerLabel = (o: Rec["owner"]) =>
!o ? "—" : (typeof o === "string" || typeof o === "number") ? String(o) : (o.username || String(o.id ?? "—"));
function ownerLabel(o: Rec["owner"]) {
if (!o) return "—";
if (typeof o === "string" || typeof o === "number") return String(o);
return o.username || String(o.id ?? "—");
}
const isMine = (owner: Rec["owner"], meId: string | null) =>
!!meId && !!owner && ((typeof owner === "string" || typeof owner === "number") ? String(owner) === meId : (owner.id != null && String(owner.id) === meId));
const resolveFileId = (v: Rec["photo"]): string | null =>
v == null ? null : (typeof v === "string" || typeof v === "number") ? String(v) : v.id ? String(v.id) : null;
// ✅ Use public Directus assets (works on your stack). Fallback to proxy if no base configured.
// Prefer public assets if available (avoids auth cookie issues in <img>)
const API_BASE = (process.env.NEXT_PUBLIC_API_BASE_URL || "").replace(/\/$/, "");
function fileUrl(id?: string) {
if (!id) return "";
return API_BASE ? `${API_BASE}/assets/${id}` : `/api/dx/assets/${id}`;
}
function ZoomableSquareImage(props: { src: string; alt: string; onOpen: () => void }) {
const { src, alt, onOpen } = props;
return (
<div className="border rounded overflow-hidden" style={{ aspectRatio: "1 / 1" }}>
<img
src={src}
alt={alt}
className="w-full h-full object-cover cursor-zoom-in"
loading="lazy"
onClick={onOpen}
onError={(e) => { (e.currentTarget as HTMLImageElement).style.display = "none"; }}
/>
</div>
);
}
export default function CO2GalvoDetail({
id,
mode,
@ -78,10 +93,8 @@ export default function CO2GalvoDetail({
const [loading, setLoading] = useState(true);
const [err, setErr] = useState<string | null>(null);
// Current user id to gate the Edit button
const [meId, setMeId] = useState<string | null>(null);
const [lightbox, setLightbox] = useState<{ src: string; alt: string } | null>(null);
// me id (for owner-gated Edit button)
useEffect(() => {
let dead = false;
(async () => {
@ -89,14 +102,22 @@ export default function CO2GalvoDetail({
const r = await fetch(`/api/dx/users/me?fields=id`, { cache: "no-store", credentials: "include" });
if (!r.ok) return;
const j = await readJson(r);
const mid = j?.data?.id ?? j?.id ?? null;
if (!dead) setMeId(mid ? String(mid) : null);
const id = j?.data?.id ?? j?.id ?? null;
if (!dead) setMeId(id ? String(id) : null);
} catch { /* ignore */ }
})();
return () => { dead = true; };
}, []);
// load record (readable fields)
// lightbox
const [viewerSrc, setViewerSrc] = useState<string | null>(null);
useEffect(() => {
const onKey = (e: KeyboardEvent) => { if (e.key === "Escape") setViewerSrc(null); };
if (viewerSrc) window.addEventListener("keydown", onKey);
return () => window.removeEventListener("keydown", onKey);
}, [viewerSrc]);
// load record (with human-readable fields, +laser_soft.name)
useEffect(() => {
if (!id) return;
let dead = false;
@ -107,19 +128,49 @@ export default function CO2GalvoDetail({
setErr(null);
const fields = [
"submission_id","setting_title","setting_notes",
"photo.id","screen.id",
"mat.id","mat.name","mat_coat.id","mat_coat.name","mat_color.id","mat_color.name","mat_opacity.id","mat_opacity.opacity","mat_thickness",
"source.submission_id","source.make","source.model","source.nm",
"lens.id","lens.field_size","lens.focal_length",
"focus","laser_soft","repeat_all",
"fill_settings","line_settings","raster_settings",
"owner.id","owner.username","uploader","last_modified_date",
"submission_id",
"setting_title",
"setting_notes",
"photo.id",
"screen.id",
"mat.id",
"mat.name",
"mat_coat.id",
"mat_coat.name",
"mat_color.id",
"mat_color.name",
"mat_opacity.id",
"mat_opacity.opacity",
"mat_thickness",
"source.submission_id",
"source.make",
"source.model",
"source.nm",
"lens.id",
"lens.field_size",
"lens.focal_length",
"focus",
"laser_soft.id",
"laser_soft.name",
"repeat_all",
"fill_settings",
"line_settings",
"raster_settings",
"owner.id",
"owner.username",
"uploader",
"last_modified_date",
].join(",");
const url = `/api/dx/items/settings_co2gal?fields=${encodeURIComponent(
fields
)}&filter[submission_id][_eq]=${encodeURIComponent(String(id))}&limit=1`;
const url = `/api/dx/items/settings_co2gal?fields=${encodeURIComponent(fields)}&filter[submission_id][_eq]=${encodeURIComponent(
String(id)
)}&limit=1`;
const r = await fetch(url, { cache: "no-store", credentials: "include" });
if (!r.ok) {
@ -140,13 +191,12 @@ export default function CO2GalvoDetail({
return () => { dead = true; };
}, [id]);
// initial values for edit form
const initialValues = useMemo(() => {
if (!rec) return null;
const toId = (v: any) => (v == null ? null : typeof v === "object" ? v.id ?? v.submission_id ?? null : v);
const toId = (v: any) => (v == null ? null : (typeof v === "object" ? (v.id ?? v.submission_id ?? null) : v));
const photoId = resolveFileId(rec.photo);
const screenId = resolveFileId(rec.screen);
const photoId = typeof rec.photo === "string" || typeof rec.photo === "number" ? String(rec.photo) : rec.photo?.id ?? null;
const screenId = typeof rec.screen === "string" || typeof rec.screen === "number" ? String(rec.screen) : rec.screen?.id ?? null;
const matId = toId(rec.mat);
const coatId = toId(rec.mat_coat);
@ -158,35 +208,29 @@ export default function CO2GalvoDetail({
return {
setting_title: rec.setting_title ?? "",
setting_notes: rec.setting_notes ?? "",
photo: photoId,
photo: photoId,
screen: screenId,
mat: matId ? String(matId) : null,
mat_coat: coatId ? String(coatId) : null,
mat_color: colorId ? String(colorId) : null,
mat_opacity: opacityId ? String(opacityId) : null,
mat_thickness: rec.mat_thickness ?? null,
source: sourceId != null ? String(sourceId) : null,
lens: lensId != null ? String(lensId) : null,
focus: rec.focus ?? null,
laser_soft: rec.laser_soft ?? null,
laser_soft: (typeof rec.laser_soft === "object" ? rec.laser_soft?.id : (rec.laser_soft as any)) ?? null,
repeat_all: rec.repeat_all ?? null,
fill_settings: rec.fill_settings ?? [],
line_settings: rec.line_settings ?? [],
fill_settings: rec.fill_settings ?? [],
line_settings: rec.line_settings ?? [],
raster_settings: rec.raster_settings ?? [],
};
}, [rec]);
// derive image URLs directly (no proxy/blob)
const photoUrl = useMemo(() => {
const pid = resolveFileId(rec?.photo ?? null);
return pid ? fileUrl(pid) : null;
}, [rec?.photo]);
const screenUrl = useMemo(() => {
const sid = resolveFileId(rec?.screen ?? null);
return sid ? fileUrl(sid) : null;
}, [rec?.screen]);
function clearEditParam() {
const params = new URLSearchParams(sp.toString());
params.delete("edit");
@ -201,15 +245,13 @@ export default function CO2GalvoDetail({
);
if (!rec) return <p className="p-6">Setting not found.</p>;
// EDIT mode
// ── EDIT MODE ───────────────────────────────────────────────
if (editMode && initialValues) {
return (
<main className="space-y-4">
<div className="flex items-center justify-between">
<h1 className="text-xl lg:text-2xl font-semibold">Edit CO Galvo Setting</h1>
<button className="px-2 py-1 border rounded text-xs" onClick={() => (onBack ? onBack() : clearEditParam())}>
Cancel
</button>
<button className="px-2 py-1 border rounded" onClick={() => (onBack ? onBack() : clearEditParam())}>Cancel</button>
</div>
<SettingsSubmit
mode="edit"
@ -221,9 +263,24 @@ export default function CO2GalvoDetail({
);
}
// VIEW mode
// ── VIEW MODE (readable) ───────────────────────────────────
const ownerDisplay = ownerLabel(rec.owner);
const canEdit = showOwnerEdit && isMine(rec.owner, meId);
const ownerId = typeof rec.owner === "object" ? (rec.owner?.id != null ? String(rec.owner.id) : null) : (rec.owner != null ? String(rec.owner) : null);
const isMine = meId && ownerId ? meId === ownerId : false;
const photoId = typeof rec.photo === "object" ? rec.photo?.id : (rec.photo as any);
const screenId = typeof rec.screen === "object" ? rec.screen?.id : (rec.screen as any);
const photoSrc = photoId ? fileUrl(String(photoId)) : "";
const screenSrc = screenId ? fileUrl(String(screenId)) : "";
const softName = typeof rec.laser_soft === "object" ? (rec.laser_soft?.name ?? "—") : "—";
function openEdit() {
const q = new URLSearchParams(sp.toString());
q.set("edit", "1");
router.replace(`?${q.toString()}`, { scroll: false });
}
return (
<div className="space-y-6">
@ -233,7 +290,6 @@ export default function CO2GalvoDetail({
</header>
<section className="grid md:grid-cols-2 gap-6">
{/* Meta */}
<div className="space-y-2">
<div className="text-sm">
<div><span className="font-medium">Owner:</span> {ownerDisplay}</div>
@ -246,7 +302,7 @@ export default function CO2GalvoDetail({
<div><span className="font-medium">Laser Source:</span> {[rec.source?.make, rec.source?.model].filter(Boolean).join(" ") || "—"}{rec.source?.nm ? ` (${rec.source.nm})` : ""}</div>
<div><span className="font-medium">Scan Lens:</span> {rec.lens?.field_size || "—"}{rec.lens?.focal_length ? ` / ${rec.lens.focal_length} mm` : ""}</div>
<div><span className="font-medium">Focus (mm):</span> {rec.focus ?? "—"}</div>
<div><span className="font-medium">Software:</span> {rec.laser_soft ?? "—"}</div>
<div><span className="font-medium">Software:</span> {softName}</div>
<div><span className="font-medium">Repeat All:</span> {rec.repeat_all ?? "—"}</div>
</div>
@ -257,58 +313,24 @@ export default function CO2GalvoDetail({
</div>
) : null}
{canEdit && (
{showOwnerEdit && isMine && (
<div className="pt-2">
<button
type="button"
onClick={() =>
router.push(`/portal/laser-settings?t=co2-galvo&view=detail&id=${rec.submission_id}&edit=1`)
}
className="inline-flex items-center rounded border px-2 py-1 text-xs hover:bg-muted"
>
Edit
</button>
<button onClick={openEdit} className="px-2 py-1 border rounded text-sm">Edit</button>
</div>
)}
</div>
{/* Images: 1:1 thumbs + click to enlarge; only render when we have a URL */}
<div className="grid grid-cols-2 gap-4">
{photoUrl ? (
<figure className="border rounded overflow-hidden">
<button
type="button"
onClick={() => setLightbox({ src: photoUrl, alt: "Result" })}
className="block w-full max-w-[320px] aspect-square"
>
<img
src={photoUrl}
alt="Result"
className="w-full h-full object-cover"
loading="lazy"
onError={(e) => { (e.currentTarget as HTMLImageElement).style.display = "none"; }}
/>
</button>
<figcaption className="text-xs p-1 text-muted-foreground">Result</figcaption>
{photoSrc ? (
<figure className="space-y-1">
<ZoomableSquareImage src={photoSrc} alt="Result" onOpen={() => setViewerSrc(photoSrc)} />
<figcaption className="text-xs text-muted-foreground">Result</figcaption>
</figure>
) : null}
{screenUrl ? (
<figure className="border rounded overflow-hidden">
<button
type="button"
onClick={() => setLightbox({ src: screenUrl, alt: "Settings Screenshot" })}
className="block w-full max-w-[320px] aspect-square"
>
<img
src={screenUrl}
alt="Settings Screenshot"
className="w-full h-full object-cover"
loading="lazy"
onError={(e) => { (e.currentTarget as HTMLImageElement).style.display = "none"; }}
/>
</button>
<figcaption className="text-xs p-1 text-muted-foreground">Settings Screenshot</figcaption>
{screenSrc ? (
<figure className="space-y-1">
<ZoomableSquareImage src={screenSrc} alt="Settings Screenshot" onOpen={() => setViewerSrc(screenSrc)} />
<figcaption className="text-xs text-muted-foreground">Settings Screenshot</figcaption>
</figure>
) : null}
</div>
@ -420,19 +442,9 @@ export default function CO2GalvoDetail({
</section>
)}
{lightbox && (
<div
className="fixed inset-0 z-50 bg-black/80 flex items-center justify-center p-4"
onClick={() => setLightbox(null)}
role="dialog"
aria-modal="true"
>
<img
src={lightbox.src}
alt={lightbox.alt}
className="max-w-[90vw] max-h-[90vh] object-contain rounded"
onClick={(e) => e.stopPropagation()}
/>
{viewerSrc && (
<div className="fixed inset-0 z-50 bg-black/80 p-4 flex items-center justify-center" onClick={() => setViewerSrc(null)}>
<img src={viewerSrc} alt="" className="max-w-full max-h-full cursor-zoom-out" onClick={(e) => e.stopPropagation()} />
</div>
)}
</div>